Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058633002: nanobench does not need to handle failed rewind. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 8 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nanobench does not need to handle failed rewind. Now that all SkCodecs can rewind (assuming the stream is rewindable), we do not need to special case it. Pointed out by Derek in the code review that added this. TBR=djsollen Committed: https://skia.googlesource.com/skia/+/081a8a4f843508484c8915860effc4aa9c3b8fcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M bench/nanobench.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058633002/1
5 years, 8 months ago (2015-04-01 21:21:43 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 21:34:43 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/081a8a4f843508484c8915860effc4aa9c3b8fcc

Powered by Google App Engine
This is Rietveld 408576698