Issue 1058613008: toolchain_build: Build glibc-flavored gcc_libs and sdk_libs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1058613008: toolchain_build: Build glibc-flavored gcc_libs and sdk_libs (Closed)

Created:
5 years, 8 months ago by Roland McGrath

Modified:
5 years, 8 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

More Reviews

Description

toolchain_build: Build glibc-flavored gcc_libs and sdk_libs This completes the glibc toolchain build with the GCC target libraries (libstdc++ et al), and the non-"raw" variant of the toolchain. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3068 TEST= toolchain trybots R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/dcd22d4aa1c4262f84a84805ce28ab9edc7b9dfd

Patch Set 2 : variable name #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -52 lines)			Patch
	M	toolchain_build/toolchain_build.py	View	1	12 chunks	+74 lines, -52 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Derek Schuff

lgtm https://codereview.chromium.org/1058613008/diff/1/toolchain_build/toolchain_build.py File toolchain_build/toolchain_build.py (right): https://codereview.chromium.org/1058613008/diff/1/toolchain_build/toolchain_build.py#newcode717 toolchain_build/toolchain_build.py:717: GCC_NEWLIB = [ how about calling this GCC_NEWLIB_CONFIGURE ...

5 years, 8 months ago (2015-04-23 19:48:10 UTC) #2

Roland McGrath

5 years, 8 months ago (2015-04-23 19:59:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dcd22d4aa1c4262f84a84805ce28ab9edc7b9dfd (presubmit successful).

Expand Messages | Collapse Messages

Issue 1058613008: toolchain_build: Build glibc-flavored gcc_libs and sdk_libs (Closed)

Description

Patch Set 1 #

Patch Set 2 : variable name #

Messages