Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1058613005: NaCl/GYP: remove references to prep_toolchain. (Closed)

Created:
5 years, 8 months ago by Nick Bray (chromium)
Modified:
5 years, 8 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

NaCl/GYP: remove references to prep_toolchain in ICU. prep_toolchain is now a no-op. BUG=456902 R=jshin@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/f8c0e585b0a046d83d72b5d37356cb50d5b2031a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M icu_nacl.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nick Bray (chromium)
Is it appropriate to patch this file directly, or do I need to do is ...
5 years, 8 months ago (2015-04-20 21:43:06 UTC) #2
jungshik at Google
On 2015/04/20 21:43:06, Nick Bray (chromium) wrote: > Is it appropriate to patch this file ...
5 years, 8 months ago (2015-04-21 13:08:20 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-21 16:03:11 UTC) #6
Nick Bray (chromium)
Committed patchset #1 (id:1) manually as f8c0e585b0a046d83d72b5d37356cb50d5b2031a (presubmit successful).
5 years, 8 months ago (2015-04-21 16:07:59 UTC) #7
jungshik at Google
On 2015/04/21 16:07:59, Nick Bray (chromium) wrote: > Committed patchset #1 (id:1) manually as > ...
5 years, 8 months ago (2015-04-21 18:59:13 UTC) #8
Nick Bray (chromium)
5 years, 8 months ago (2015-04-21 19:05:38 UTC) #9
Message was sent while issue was closed.
I was going to do 3 related DEPS rolls at once, currently hung up on this one:
https://webrtc-codereview.appspot.com/51699004/

Powered by Google App Engine
This is Rietveld 408576698