Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058603004: [Approach 3] Pre-allocate IncomigTaskQueue before MessageLoop for faster thread startup

Created:
5 years, 8 months ago by kinuko
Modified:
5 years, 8 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, sadrul, zea+watch_chromium.org, feature-media-reviews_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, asvitkine+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pre-allocate IncomigTaskQueue before MessageLoop for faster thread startup Approach 3 in the doc: https://docs.google.com/a/chromium.org/document/d/1o1vUUOjX3tC7pV5-nxchaGtElo4NwtzKOAb4Zm09ezw/edit (This does not compile) BUG=465458

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -157 lines) Patch
M base/message_loop/incoming_task_queue.h View 4 chunks +17 lines, -3 lines 0 comments Download
M base/message_loop/incoming_task_queue.cc View 4 chunks +20 lines, -9 lines 0 comments Download
M base/message_loop/message_loop.h View 5 chunks +30 lines, -7 lines 0 comments Download
M base/message_loop/message_loop.cc View 5 chunks +39 lines, -3 lines 0 comments Download
M base/threading/platform_thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/threading/thread.h View 1 2 10 chunks +29 lines, -29 lines 0 comments Download
M base/threading/thread.cc View 2 7 chunks +126 lines, -76 lines 0 comments Download
M base/threading/thread_id_name_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/public/browser/browser_thread_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/test/test_browser_thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/test/test_browser_thread.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
kinuko
Patchset #1 (id:1) has been deleted
5 years, 8 months ago (2015-04-13 13:52:20 UTC) #1
kinuko
5 years, 8 months ago (2015-04-13 13:57:04 UTC) #2 
Patchset #1 (id:20001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698