Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1058553004: [crankshaft] Add missing source position for calls. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Add missing source position for calls. R=verwaest@chromium.org TEST=cctest/test-api BUG=v8:3995 LOG=N Committed: https://crrev.com/969475b604fd1e5f9a76d2c40b79877fe97cbe4a Cr-Commit-Position: refs/heads/master@{#27843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +5 lines, -15 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-13 14:27:09 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-15 11:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058553004/1
5 years, 8 months ago (2015-04-15 11:38:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 12:48:55 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:49:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/969475b604fd1e5f9a76d2c40b79877fe97cbe4a
Cr-Commit-Position: refs/heads/master@{#27843}

Powered by Google App Engine
This is Rietveld 408576698