Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/arm/assembler-arm.cc

Issue 1058533007: Fix a few potential integer negation overflows (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | src/arm64/lithium-codegen-arm64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index f82df461258d214b31e3fe6c260e4344d4dcf5fd..da1ab68a76d0ae1bf47d35444df3f51524ad314a 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -2209,6 +2209,7 @@ void Assembler::vldr(const DwVfpRegister dst,
// Vd(15-12) | 1011(11-8) | offset
int u = 1;
if (offset < 0) {
+ CHECK(offset != kMinInt);
offset = -offset;
u = 0;
}
@@ -2305,6 +2306,7 @@ void Assembler::vstr(const DwVfpRegister src,
// Vd(15-12) | 1011(11-8) | (offset/4)
int u = 1;
if (offset < 0) {
+ CHECK(offset != kMinInt);
offset = -offset;
u = 0;
}
@@ -2353,6 +2355,7 @@ void Assembler::vstr(const SwVfpRegister src,
// Vdst(15-12) | 1010(11-8) | (offset/4)
int u = 1;
if (offset < 0) {
+ CHECK(offset != kMinInt);
offset = -offset;
u = 0;
}
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | src/arm64/lithium-codegen-arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698