Implement a background downloader using BITS in Windows Chrome.

chrome/browser/component_updater/test/component_updater_service_unittest.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_UPDATER_SERVICE_UNITTEST_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_UPDATER_SERVICE_UNITTEST_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 46 matching lines @@
                            0x06, 0x06, 0x06, 0x06, 0x06, 0x06, 0x06, 0x01};
 // component 3 has extension id "ihfokbkgjpifnbbojhneepfflplebdkc", and
 // the RSA public key the following hash:
 const uint8 ihfo_hash[] = {0x87, 0x5e, 0xa1, 0xa6, 0x9f, 0x85, 0xd1, 0x1e,
                            0x97, 0xd4, 0x4f, 0x55, 0xbf, 0xb4, 0x13, 0xa2,
                            0xe7, 0xc5, 0xc8, 0xf5, 0x60, 0x19, 0x78, 0x1b,
                            0x6d, 0xe9, 0x4c, 0xeb, 0x96, 0x05, 0x42, 0x17};
 
 class TestConfigurator : public ComponentUpdateService::Configurator {
  public:
-  explicit TestConfigurator();
-
+  TestConfigurator();
   virtual ~TestConfigurator();
 
+  // Overrrides for ComponentUpdateService::Configurator.
   virtual int InitialDelay() OVERRIDE;
+  virtual int NextCheckDelay() OVERRIDE;
+  virtual int StepDelay() OVERRIDE;
+  virtual int StepDelayMedium() OVERRIDE;
+  virtual int MinimumReCheckWait() OVERRIDE;
+  virtual int OnDemandDelay() OVERRIDE;
+  virtual GURL UpdateUrl() OVERRIDE;
+  virtual GURL PingUrl() OVERRIDE;
+  virtual const char* ExtraRequestParams() OVERRIDE;
+  virtual size_t UrlSizeLimit() OVERRIDE;
+  virtual net::URLRequestContextGetter* RequestContext() OVERRIDE;
+  virtual bool InProcess() OVERRIDE;
+  virtual ComponentPatcher* CreateComponentPatcher() OVERRIDE;
+  virtual bool DeltasEnabled() const OVERRIDE;
+  virtual bool UseBackgroundDownloader() const OVERRIDE;

[waffles, 2013/12/05 01:15:07]

Can we also remove the extra \n from the non-virtuals below? I realize that you
removed them here so that the comment was "scoped" around these, but I'm not
sure I like that these are condensed but nothing else is.

[Sorin Jianu, 2013/12/05 01:43:07]

Done.

[Sorin Jianu, 2013/12/05 01:43:07]

Done.

 
   typedef std::pair<CrxComponent*, int> CheckAtLoopCount;
 
-  virtual int NextCheckDelay() OVERRIDE;
-
-  virtual int StepDelay() OVERRIDE;
-
-  virtual int StepDelayMedium() OVERRIDE;
-
-  virtual int MinimumReCheckWait() OVERRIDE;
-
-  virtual int OnDemandDelay() OVERRIDE;
-
-  virtual GURL UpdateUrl() OVERRIDE;
-
-  virtual GURL PingUrl() OVERRIDE;
-
-  virtual const char* ExtraRequestParams() OVERRIDE;
-
-  virtual size_t UrlSizeLimit() OVERRIDE;
-
-  virtual net::URLRequestContextGetter* RequestContext() OVERRIDE;
-
-  // Don't use the utility process to run component updater code.
-  virtual bool InProcess() OVERRIDE;
-
-  virtual ComponentPatcher* CreateComponentPatcher() OVERRIDE;
-
-  virtual bool DeltasEnabled() const OVERRIDE;
-
   void SetLoopCount(int times);
 
   void SetRecheckTime(int seconds);
 
   void SetOnDemandTime(int seconds);
 
   void SetComponentUpdateService(ComponentUpdateService* cus);
 
   void SetQuitClosure(const base::Closure& quit_closure);
 
@@ skipping 65 matching lines @@
 
 class OnDemandTester {
  public:
   static ComponentUpdateService::Status OnDemand(
       ComponentUpdateService* cus, const std::string& component_id);
 };
 
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_UPDATER_SERVICE_UNITTEST_H_