Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1058523002: Add ConstThreadState to mach_extensions.h and use it everywhere (Closed)

Created:
5 years, 8 months ago by Mark Mentovai
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add ConstThreadState to mach_extensions.h and use it everywhere. TEST=everything R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/40b1d7cb1d9e22bdc588dd8d2fe76e5688e41616

Patch Set 1 #

Patch Set 2 : clang-unformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -67 lines) Patch
M client/simulate_crash_mac.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M client/simulate_crash_mac_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/crash_report_exception_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/crash_report_exception_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/exception_handler_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/cpu_context_mac.h View 3 chunks +3 lines, -2 lines 0 comments Download
M snapshot/mac/cpu_context_mac.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M snapshot/mac/exception_snapshot_mac.h View 2 chunks +2 lines, -1 line 0 comments Download
M snapshot/mac/exception_snapshot_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M snapshot/mac/process_snapshot_mac.h View 2 chunks +2 lines, -1 line 0 comments Download
M snapshot/mac/process_snapshot_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/catch_exception_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_client_variants.h View 2 chunks +3 lines, -1 line 0 comments Download
M util/mach/exc_client_variants.cc View 2 chunks +1 line, -2 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants.h View 3 chunks +3 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 13 chunks +27 lines, -27 lines 0 comments Download
M util/mach/exception_ports_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/mach_extensions.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
Following up from https://codereview.chromium.org/1049023003/, I noticed that we already had a ConstThreadState in client/simulate_crash_mac.cc. It’s ...
5 years, 8 months ago (2015-04-01 16:34:57 UTC) #2
Mark Mentovai
The 8 lines was actually just clang-format being a jerk. This is really a gain ...
5 years, 8 months ago (2015-04-01 16:38:52 UTC) #3
Robert Sesek
LGTM. I didn't check IWYU everywhere, though.
5 years, 8 months ago (2015-04-02 19:26:39 UTC) #4
Mark Mentovai
5 years, 8 months ago (2015-04-02 19:28:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
40b1d7cb1d9e22bdc588dd8d2fe76e5688e41616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698