Add an Accounts in Token Service section to about:signin-internals.

Add an Accounts in Token Service section to about:signin-internals.

This CL also sorts the "access token details by account" section of the
page by request time.

BUG=405038
Committed: https://crrev.com/f1becdc3e449c688eef54cf1e564d1176fe79fdc
Cr-Commit-Position: refs/heads/master@{#324066}

[anthonyvd, 2015-04-01 16:11:03]

anthonyvd@chromium.org changed reviewers:
+ jhawkins@chromium.org, rogerta@chromium.org

[anthonyvd, 2015-04-01 16:11:03]

Hi guys, could you take a quick look at this sigin-internals change?

rogerta@chromium.org: components/signin/core/browser
jhawkins@chromium.org: chrome/browser/resources

Thanks!

[James Hawkins, 2015-04-01 16:19:44]

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
File chrome/browser/resources/signin_internals/signin_index.html (right):

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:70: <div
id='account-info'>
nit: Double quotes.

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:72: <div
class="accountSection">
nit: account-section

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:77: <tr
jsselect="account_info">
Per my comments in the WebUI handler, these need to be accountInfo and
accountId.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:600:
signin_status->Set("account_info", account_info);
nit: accountInfo, since this is ultimately a JS variable.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:606:
no_token_entry->SetString("account_id", "No token in Token Service.");
nit: accountId, since this is ultimately a JS variable.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:612:
entry->SetString("account_id", account_id);
nit: accountId, since this is ultimately a JS variable.

[Roger Tawa OOO till Jul 10th, 2015-04-01 16:53:40]

lgtm

[anthonyvd, 2015-04-07 15:16:07]

Feedback addressed, thanks!

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
File chrome/browser/resources/signin_internals/signin_index.html (right):

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:70: <div
id='account-info'>
On 2015/04/01 16:19:44, James Hawkins wrote:
> nit: Double quotes.

Done.

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:72: <div
class="accountSection">
On 2015/04/01 16:19:44, James Hawkins wrote:
> nit: account-section

Done.

https://codereview.chromium.org/1058513002/diff/1/chrome/browser/resources/si...
chrome/browser/resources/signin_internals/signin_index.html:77: <tr
jsselect="account_info">
On 2015/04/01 16:19:44, James Hawkins wrote:
> Per my comments in the WebUI handler, these need to be accountInfo and
> accountId.

Done.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:600:
signin_status->Set("account_info", account_info);
On 2015/04/01 16:19:44, James Hawkins wrote:
> nit: accountInfo, since this is ultimately a JS variable.

Done.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:606:
no_token_entry->SetString("account_id", "No token in Token Service.");
On 2015/04/01 16:19:44, James Hawkins wrote:
> nit: accountId, since this is ultimately a JS variable.

Done.

https://codereview.chromium.org/1058513002/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:612:
entry->SetString("account_id", account_id);
On 2015/04/01 16:19:44, James Hawkins wrote:
> nit: accountId, since this is ultimately a JS variable.

Done.

[James Hawkins, 2015-04-07 15:17:30]

lgtm

[anthonyvd, 2015-04-07 15:18:09]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2015-04-07 15:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1058513002/#ps20001
(title: "Address feedback")

[commit-bot: I haz the power, 2015-04-07 15:18:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058513002/20001

[commit-bot: I haz the power, 2015-04-07 15:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 15:23:18]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[anthonyvd, 2015-04-07 16:23:23]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2015-04-07 16:23:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, jhawkins@chromium.org
Link to the patchset: https://codereview.chromium.org/1058513002/#ps40001
(title: "Rebase before submit")

[commit-bot: I haz the power, 2015-04-07 16:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058513002/40001

[commit-bot: I haz the power, 2015-04-07 17:51:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 17:52:16]

Patchset 3 (id:??) landed as
https://crrev.com/f1becdc3e449c688eef54cf1e564d1176fe79fdc
Cr-Commit-Position: refs/heads/master@{#324066}