PRESUBMIT.py - Issue 1058483002: Find the HASHTAGS file even if you are not at the checkout root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1058483002: Find the HASHTAGS file even if you are not at the checkout root (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 8b60774de5fff6f67ad7f40b3181ac2176a8052c..a036be6fc84876ed218d9a52441511a40a1c2bd1 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -392,7 +392,8 @@ def PostUploadHook(cl, change, output_api):

'Automatically added \'NOTRY=true\' to the CL\'s description'))

# Read and process the HASHTAGS file.

- with open('HASHTAGS', 'rb') as hashtags_csv:

+ hashtags_fullpath = os.path.join(change._local_root, 'HASHTAGS')

+ with open(hashtags_fullpath, 'rb') as hashtags_csv:

hashtags_reader = csv.reader(hashtags_csv, delimiter=',')

for row in hashtags_reader:

if not row or row[0].startswith('#'):

« no previous file with comments | « no previous file | no next file » | no next file with comments »