Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058473002: Use the new Wallet risk data API. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, stuppy_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the new risk data format in GetRealPanRequest. See http://cl/89930394 for the Wallet change. The alternative approach made possible by the new parameter will be used in a subsequent change downstream in the Bling repository. Verified on desktop with a successful card verification on prod. BUG= Committed: https://crrev.com/23cb362e78184197f00f2d136ad1e7f148ef2a88 Cr-Commit-Position: refs/heads/master@{#323367}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M components/autofill/core/browser/card_unmask_delegate.h View 1 chunk +4 lines, -0 lines 2 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Justin Donnelly
5 years, 8 months ago (2015-04-01 15:08:08 UTC) #3
Evan Stade
lgtm, thanks
5 years, 8 months ago (2015-04-01 23:15:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058473002/20001
5 years, 8 months ago (2015-04-01 23:19:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-01 23:23:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/23cb362e78184197f00f2d136ad1e7f148ef2a88 Cr-Commit-Position: refs/heads/master@{#323367}
5 years, 8 months ago (2015-04-01 23:24:45 UTC) #8
Evan Stade
https://codereview.chromium.org/1058473002/diff/20001/components/autofill/core/browser/card_unmask_delegate.h File components/autofill/core/browser/card_unmask_delegate.h (right): https://codereview.chromium.org/1058473002/diff/20001/components/autofill/core/browser/card_unmask_delegate.h#newcode37 components/autofill/core/browser/card_unmask_delegate.h:37: bool providing_risk_advisory_data = false; oops, I didn't catch this ...
5 years, 7 months ago (2015-05-20 22:43:05 UTC) #9
Justin Donnelly
5 years, 7 months ago (2015-05-20 23:03:35 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1058473002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/card_unmask_delegate.h (right):

https://codereview.chromium.org/1058473002/diff/20001/components/autofill/cor...
components/autofill/core/browser/card_unmask_delegate.h:37: bool
providing_risk_advisory_data = false;
On 2015/05/20 22:43:05, Evan Stade wrote:
> oops, I didn't catch this before --- this is not the correct way to init. See
> card_unmask_delegate.cc

Fixed in https://codereview.chromium.org/1148123003/.

Powered by Google App Engine
This is Rietveld 408576698