Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058463004: Update windows suppressions and unify across platforms (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : redundant comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -90 lines) Patch
M testing/SUPPRESSIONS View 1 chunk +45 lines, -0 lines 0 comments Download
M testing/SUPPRESSIONS_linux View 1 chunk +0 lines, -45 lines 0 comments Download
M testing/SUPPRESSIONS_mac View 5 chunks +0 lines, -45 lines 0 comments Download
M testing/SUPPRESSIONS_win View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, please review.
5 years, 8 months ago (2015-04-01 17:36:05 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1058463004/diff/1/testing/SUPPRESSIONS_win File testing/SUPPRESSIONS_win (right): https://codereview.chromium.org/1058463004/diff/1/testing/SUPPRESSIONS_win#newcode3 testing/SUPPRESSIONS_win:3: # List of tests to be skipped on ...
5 years, 8 months ago (2015-04-01 17:52:31 UTC) #3
Tom Sepez
https://codereview.chromium.org/1058463004/diff/1/testing/SUPPRESSIONS_win File testing/SUPPRESSIONS_win (right): https://codereview.chromium.org/1058463004/diff/1/testing/SUPPRESSIONS_win#newcode3 testing/SUPPRESSIONS_win:3: # List of tests to be skipped on windows ...
5 years, 8 months ago (2015-04-01 18:42:22 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-01 18:42:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7e75ed5a0a828272219417551d736349fc7e86ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698