[cros login, new GAIA] New UI for not authorized error

[cros login, new GAIA] New UI for not authorized error

Drop "offline sign in" help article reference since HelpApp doesn't have that content.

BUG=468257, 469459
Committed: https://crrev.com/34e45cb7fca19022afda5eea74a8e73d7fe9aef2
Cr-Commit-Position: refs/heads/master@{#324421}

[Nikita (slow), 2015-04-06 18:57:41]

nkostylev@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Nikita (slow), 2015-04-06 18:57:42]

https://codereview.chromium.org/1058433002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/login.html (right):

https://codereview.chromium.org/1058433002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/login.html:12: <include
src="gaia_whitelist_error.html">
I'll move this to login/custom_elements.html once Roman lands his CL.

https://codereview.chromium.org/1058433002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/login.js (right):

https://codereview.chromium.org/1058433002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/login.js:10: <include
src="gaia_whiteist_error.js">
I'll move this to login/custom_elements.js once Roman lands his CL.

[Nikita (slow), 2015-04-07 08:44:24]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-07 08:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058433002/140001

[commit-bot: I haz the power, 2015-04-07 08:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 08:49:27]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nikita (slow), 2015-04-07 09:28:04]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-07 09:28:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058433002/160001

[commit-bot: I haz the power, 2015-04-07 09:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 09:37:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-07 09:49:38]

Patchset #10 (id:180001) has been deleted

[dzhioev (left Google), 2015-04-07 17:16:57]

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/gaia_whitelist_error.html (right):

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:40: <div flex
two layout center vertical>
Please fix indentation.

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:56: <div
id="controls-container" horizontal layout around-justified
Let's make controls bar height fixed, as discussed.

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:785:
showWhitelistCheckFailedError: function(show, opt_data) {
Are you planning to use |opt_data| for something more, than passing
|enterpriseManaged| value?

[Nikita (slow), 2015-04-08 16:55:20]

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/gaia_whitelist_error.html (right):

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:40: <div flex
two layout center vertical>
On 2015/04/07 17:16:57, dzhioev wrote:
> Please fix indentation.

Done.

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:56: <div
id="controls-container" horizontal layout around-justified
On 2015/04/07 17:16:57, dzhioev wrote:
> Let's make controls bar height fixed, as discussed.

Done.

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:785:
showWhitelistCheckFailedError: function(show, opt_data) {
On 2015/04/07 17:16:57, dzhioev wrote:
> Are you planning to use |opt_data| for something more, than passing
> |enterpriseManaged| value?

Done.

https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:785:
showWhitelistCheckFailedError: function(show, opt_data) {
On 2015/04/07 17:16:57, dzhioev wrote:
> Are you planning to use |opt_data| for something more, than passing
> |enterpriseManaged| value?

Seems to be a better way to handle the fact that it may be optional and
something might be added there.

[dzhioev (left Google), 2015-04-09 11:44:28]

On 2015/04/08 16:55:20, Nikita Kostylev wrote:
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/gaia_whitelist_error.html
(right):
> 
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:40: <div
flex
> two layout center vertical>
> On 2015/04/07 17:16:57, dzhioev wrote:
> > Please fix indentation.
> 
> Done.
> 
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/gaia_whitelist_error.html:56: <div
> id="controls-container" horizontal layout around-justified
> On 2015/04/07 17:16:57, dzhioev wrote:
> > Let's make controls bar height fixed, as discussed.
> 
> Done.
> 
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):
> 
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/screen_gaia_signin.js:785:
> showWhitelistCheckFailedError: function(show, opt_data) {
> On 2015/04/07 17:16:57, dzhioev wrote:
> > Are you planning to use |opt_data| for something more, than passing
> > |enterpriseManaged| value?
> 
> Done.
> 
>
https://codereview.chromium.org/1058433002/diff/240001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/screen_gaia_signin.js:785:
> showWhitelistCheckFailedError: function(show, opt_data) {
> On 2015/04/07 17:16:57, dzhioev wrote:
> > Are you planning to use |opt_data| for something more, than passing
> > |enterpriseManaged| value?
> 
> Seems to be a better way to handle the fact that it may be optional and
> something might be added there.

LGTM

[Nikita (slow), 2015-04-09 11:46:33]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-04-09 11:46:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1058433002/#ps320001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-09 11:46:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058433002/320001

[commit-bot: I haz the power, 2015-04-09 12:54:25]

Committed patchset #16 (id:320001)

[commit-bot: I haz the power, 2015-04-09 12:55:21]

Patchset 16 (id:??) landed as
https://crrev.com/34e45cb7fca19022afda5eea74a8e73d7fe9aef2
Cr-Commit-Position: refs/heads/master@{#324421}