Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1058403002: Revert of Refactor frame navigation/detach state cleanup to be more sane. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, site-isolation-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Refactor frame navigation/detach state cleanup to be more sane. (patchset #13 id:230001 of https://codereview.chromium.org/1052993006/) Reason for revert: PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage is broken by this change. Original issue's description: > Refactor frame navigation/detach state cleanup to be more sane. > > Prior to this patch, cleaning up state for a navigating or detaching > frame was ad hoc: often times, code to do the same thing (e.g. detach > child frames) was present in multiple locations just to "be sure" that > the cleanup would happen no matter what code path was taken. > > This logic has been reorganized so that the state cleanup always follows > a similar flow for both navigation and detach. There are now 4 common > steps: > 1. FrameLoader::dispatchUnloadEvent() > 2. Frame::detachChildren() > 3. Document::prepareForDestruction() > 4. FrameLoader::clear() > > BUG=464764 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193157 TBR=japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -91 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryEvaluatorTest.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +4 lines, -10 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 4 chunks +24 lines, -3 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M Source/core/testing/DummyPageHolder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +3 lines, -11 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 8 chunks +8 lines, -17 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Refactor frame navigation/detach state cleanup to be more sane.
5 years, 8 months ago (2015-04-04 13:36:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058403002/1
5 years, 8 months ago (2015-04-04 13:36:25 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 13:37:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193158

Powered by Google App Engine
This is Rietveld 408576698