Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: content/common/sandbox_win.cc

Issue 1058373003: Adding minidump creation when launching renderer process fails in appcontainer mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 0211a1c73ced3af904dfba9bd1df4bf84585f9f6..0a25bdcf62d020e6e3671124025b9814583036eb 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -8,6 +8,7 @@
#include "base/base_switches.h"
#include "base/command_line.h"
+#include "base/debug/dump_without_crashing.h"
#include "base/debug/profiler.h"
#include "base/files/file_util.h"
#include "base/hash.h"
@@ -728,7 +729,6 @@ base::Process StartSandboxedProcess(
cmd_line->GetCommandLineString().c_str(),
policy, &temp_process_info);
DWORD last_error = ::GetLastError();
- policy->Release();
base::win::ScopedProcessInformation target(temp_process_info);
TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
@@ -745,10 +745,18 @@ base::Process StartSandboxedProcess(
"Process.Sandbox.Lowbox.Launch.Error" :
"Process.Sandbox.Launch.Error",
last_error);
+ // Trigger a minidump without crashing the browser.
+ // Note that this function will only generate minidump if content host
+ // has already done pre-setup by calling
+ // base::debug::SetDumpWithoutCrashingFunction
+ base::debug::DumpWithoutCrashing();
} else
DLOG(ERROR) << "Failed to launch process. Error: " << result;
+
+ policy->Release();
return base::Process();
}
+ policy->Release();
if (delegate)
delegate->PostSpawnTarget(target.process_handle());
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698