bluetooth: Move requestDevice() to UI thread.

bluetooth: Move requestDevice() to UI thread.

BluetoothAdapter is not thread safe, this change moves the requestDevice() call to it onto the UI thread.

BUG=420284
Committed: https://crrev.com/8a72921779123fbd7a7f756f9683f4df8944ea9d
Cr-Commit-Position: refs/heads/master@{#323919}

Committed: https://crrev.com/ca8dd4aa03e5edb6432d0decbd283467bc3b0b1f
Cr-Commit-Position: refs/heads/master@{#325153}

[ortuno, 2015-04-04 01:10:26]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-04-04 01:11:50]

Please review scheib@

[scheib, 2015-04-05 13:58:50]

Change comment needs a fix, the non-threadsafe object is BluetoothAdapter.

"BluetoothAdapter is not thread safe, this change moves the requestDevice() call
to it onto the UI thread."

I also suggest we prefix all chromium patches for bluetooth work with
"bluetooth:" to make them easier to spot. Many teams do this, but not all, and
not always consistently. When updating the title of a change set remember to do
it in the 'Subject' line and the first line of 'Description'.

After those changes, LGTM.

https://codereview.chromium.org/1058373002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1058373002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.h:41: void
OnRequestDeviceUI(int thread_id, int request_id);
OnRequestDeviceOnUI. "'normal method name'OnUI" is a common short suffix pattern
that I think we should use.

[ortuno, 2015-04-06 17:09:19]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-06 17:09:20]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1058373002/#ps20001
(title: " ")

[ortuno, 2015-04-06 17:09:26]

The CQ bit was unchecked by ortuno@chromium.org

[ortuno, 2015-04-06 17:39:01]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-04-06 17:39:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058373002/20001

[commit-bot: I haz the power, 2015-04-06 18:31:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-06 18:36:48]

Patchset 2 (id:??) landed as
https://crrev.com/8a72921779123fbd7a7f756f9683f4df8944ea9d
Cr-Commit-Position: refs/heads/master@{#323919}

[falken, 2015-04-07 01:20:39]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1048313003/ by falken@chromium.org.

The reason for reverting is: The layout test bluetooth/requestDevice.html became
flaky after this patch landed.

Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=blu...

Example failure link:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/buil...

Failure output:
This is a testharness.js-based test.
PASS window.testRunner is required for the following tests. 
PASS Reject with NotFoundError. 
FAIL Reject with SecurityError. assert_unreached: Mock was set to reject.
Reached unreachable code
PASS Mock will resolve. 
Harness: the test ran to completion..

[ortuno, 2015-04-14 22:36:33]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-14 22:36:33]

Tests where running in parallel which caused some flakiness. The flakiness was
fixed in this change https://codereview.chromium.org/1062393002.

[commit-bot: I haz the power, 2015-04-14 22:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058373002/20001

[commit-bot: I haz the power, 2015-04-14 23:59:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 00:00:19]

Patchset 2 (id:??) landed as
https://crrev.com/ca8dd4aa03e5edb6432d0decbd283467bc3b0b1f
Cr-Commit-Position: refs/heads/master@{#325153}