Simplify DoParseProgram

Simplify DoParseProgram

DoParseProgram doesn't appear to need to receive toplevel scopes as
arguments; it can properly set the end_position of the scopes to the
scanner's position after parsing is complete.

R=marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/8da9252f61d3c499a78b0b94299c314b2eb0b0c8
Cr-Commit-Position: refs/heads/master@{#27847}

[marja, 2015-04-15 13:11:23]

lgtm and thanks for the cleanup!

Huh, the state before this CL is silly!

https://codereview.chromium.org/1058363003/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1058363003/diff/1/src/parser.cc#newcode1005
src/parser.cc:1005: Scope* eval_scope = NULL;
nullptr

[wingo, 2015-04-15 13:14:52]

tx for review!

https://codereview.chromium.org/1058363003/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1058363003/diff/1/src/parser.cc#newcode1005
src/parser.cc:1005: Scope* eval_scope = NULL;
On 2015/04/15 13:11:23, marja wrote:
> nullptr

Done.

[wingo, 2015-04-15 13:14:56]

The CQ bit was checked by wingo@igalia.com

[wingo, 2015-04-15 13:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/1058363003/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2015-04-15 13:15:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058363003/20001

[commit-bot: I haz the power, 2015-04-15 13:42:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 13:42:43]

Patchset 2 (id:??) landed as
https://crrev.com/8da9252f61d3c499a78b0b94299c314b2eb0b0c8
Cr-Commit-Position: refs/heads/master@{#27847}

[Michael Achenbach, 2015-04-15 17:17:24]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-04-15 17:17:25]

This changes layout test expectations - did a needsmanualrebaseline CL land on
the blink side?

[marja, 2015-04-15 17:18:32]

Hmm, that doesn't seem intentional. At least I wouldn't have expected any
behavioral changes.

Let's revert unless wingo@ tunes in shorty.

[Michael Achenbach, 2015-04-15 17:20:15]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1089623002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Changes some layout tests on all
platforms, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2543.

[wingo, 2015-04-16 08:46:08]

On 2015/04/15 17:20:15, Michael Achenbach wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1089623002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Changes some layout tests on all
> platforms, e.g.:
>
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2543.

Tx for sherriffing; I had knocked off.  I'll make a new CL and run the layout
tests on it.