Issue 1058353002: Fix the tz detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1058353002: Fix the tz detection code. (Closed)

Created:
5 years, 8 months ago by jungshik at Google

Modified:
5 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the tz detection code. Due to caching, the 2nd timezone change is not detected properly. Upstream bug: http://bugs.icu-project.org/trac/ticket/11623 BUG=406382 TEST=manual. Call detectHostTimeZone() every time the OS tz is changed on Linux and check if it returns the correct present timezone. R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/10834e84d250eb31a73496bfdb7923eaa43ead51

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -3 lines)			Patch
M	README.chromium	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
A	patches/tzdetect2.patch	View		1 chunk	+50 lines, -0 lines	0 comments	Download
M	source/common/putil.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	source/common/putilimp.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	source/i18n/timezone.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

jungshik at Google

5 years, 8 months ago (2015-04-06 21:41:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
10834e84d250eb31a73496bfdb7923eaa43ead51 (presubmit successful).