tools/metrics/common/models.py - Issue 1058333002: Multi-dimension rappor metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/common/models.py

Issue 1058333002: Multi-dimension rappor metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add xml support Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/common/models.py

diff --git a/tools/metrics/common/models.py b/tools/metrics/common/models.py

index 3ba301c4eec8bfd368f0d983c9c24c7cb47ef4aa..bf79e57e01e4c628ccc3107f615a0c18e245b299 100644

--- a/tools/metrics/common/models.py

+++ b/tools/metrics/common/models.py

@@ -158,7 +158,8 @@ class ObjectNodeType(NodeType):

self.float_attributes +

self.string_attributes)

for attr in attributes:

- node.setAttribute(attr, str(obj[attr]))

+ if obj[attr]:

+ node.setAttribute(attr, str(obj[attr]))

PutComments(node, obj['comments'])

« no previous file with comments | « components/rappor/rappor_service_unittest.cc ('k') | tools/metrics/rappor/pretty_print.py » ('j') | no next file with comments »