Added Dev host for data reduction proxy controlled by Finch experiment.

Added Dev host for data reduction proxy controlled by Finch experiment.

This is only for Android. We don't need it for iOS at this point.

BUG=325345
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244669

[bolian, 2013-12-19 02:45:02]

This is the chromium part of the change.

[eroman, 2013-12-19 22:35:51]

https://codereview.chromium.org/105833010/diff/40001/net/proxy/proxy_server.cc
File net/proxy/proxy_server.cc (right):

https://codereview.chromium.org/105833010/diff/40001/net/proxy/proxy_server.c...
net/proxy/proxy_server.cc:217:
HostPortPair::FromURL(GURL(DATA_REDUCTION_DEV_HOST)));
what is the difference between these two defines? (data_reduction_host and
spdy_proxy_auth_origin)

[bolian, 2013-12-19 22:41:33]

https://codereview.chromium.org/105833010/diff/40001/net/proxy/proxy_server.cc
File net/proxy/proxy_server.cc (right):

https://codereview.chromium.org/105833010/diff/40001/net/proxy/proxy_server.c...
net/proxy/proxy_server.cc:217:
HostPortPair::FromURL(GURL(DATA_REDUCTION_DEV_HOST)));
We have some bad naming due to some history reasons. Here, I am following
data_reduction_fallback_host to name data_reduction_dev_host.

There is some background in the bug.  To summarize, the difference between
data_reduction_dev_host and spdy_proxy_auth_origin is that
data_reduction_dev_host could be pointed to our test server and will be
controlled by Finch to select a fraction of dev-channel users to use that, while
spdy_proxy_auth_origin points to the production server.

[bengr, 2013-12-19 23:11:15]

lgtm

https://codereview.chromium.org/105833010/diff/40001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc (right):

https://codereview.chromium.org/105833010/diff/40001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc:267: kEnabled)
Add curly braces.

[bolian, 2013-12-19 23:35:26]

https://codereview.chromium.org/105833010/diff/40001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc (right):

https://codereview.chromium.org/105833010/diff/40001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc:267: kEnabled)
On 2013/12/19 23:11:15, bengr1 wrote:
> Add curly braces.

Done.

[marq (ping after 24h), 2013-12-19 23:43:34]

https://codereview.chromium.org/105833010/diff/60001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/105833010/diff/60001/chrome/common/chrome_swi...
chrome/common/chrome_switches.h:371: extern const char
kSpdyProxyDevAuthOrigin[];
Can we not keep using "Auth" in names at least? kSpdyProxyDevOrigin[] or
(better) kDataReductionProxyDevOrigin[]

[bengr, 2013-12-20 16:52:58]

On 2013/12/19 23:43:34, marq_ wrote:
>
https://codereview.chromium.org/105833010/diff/60001/chrome/common/chrome_swi...
> File chrome/common/chrome_switches.h (right):
> 
>
https://codereview.chromium.org/105833010/diff/60001/chrome/common/chrome_swi...
> chrome/common/chrome_switches.h:371: extern const char
> kSpdyProxyDevAuthOrigin[];
> Can we not keep using "Auth" in names at least? kSpdyProxyDevOrigin[] or
> (better) kDataReductionProxyDevOrigin[]

Let's hold off on name changes. I plan to overhaul our busted naming soon.

[bolian, 2013-12-30 23:28:16]

ping. eroman@, could you take a look when get a chance?  thanks :)

[eroman, 2014-01-07 18:31:06]

The way this configuration is plumbed through and the particular names of the
command line flags still seems very weird to me.

rubber stamp LGTM for net changes.

[commit-bot: I haz the power, 2014-01-13 19:48:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/105833010/60001

[commit-bot: I haz the power, 2014-01-13 19:48:27]

Failed to apply patch for chrome/common/chrome_switches.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/common/chrome_switches.cc
  Hunk #1 FAILED at 1358.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/chrome_switches.cc.rej

Patch:       chrome/common/chrome_switches.cc
Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index
123834258e4eabb30ab21ad3e22baea2a52d6340..7f0b05309f03bda8e52e5ab6a45e24ef2d7ec45c
100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -1358,6 +1358,9 @@ const char kSpdyProxyAuthOrigin[]           =
"spdy-proxy-auth-origin";
 // Authentication string for the data reduction proxy.
 const char kSpdyProxyAuthValue[]            = "spdy-proxy-auth-value";
 
+// Origin for which dev version of SpdyProxy authentication is supported.
+const char kSpdyProxyDevAuthOrigin[]        = "spdy-proxy-dev-auth-origin";
+
 // Speculative resource prefetching.
 const char kSpeculativeResourcePrefetching[] =
     "speculative-resource-prefetching";

[commit-bot: I haz the power, 2014-01-13 23:15:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/105833010/130001

[commit-bot: I haz the power, 2014-01-14 11:17:37]

Change committed as 244669