Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 105833008: Fix trivial error when building with clang. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
titzer, Sven Panne
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix trivial error when building with clang. $ ninja -C out/Debug ... ../../src/d8.cc:171:11: error: unused variable 'MB' [-Werror,-Wunused-const-variable] const int MB = 1024 * 1024; ^ 1 error generated. R=titzer@chromium.org, svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=18276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/d8.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
7 years ago (2013-12-07 00:03:14 UTC) #1
titzer
lgtm
7 years ago (2013-12-09 10:12:23 UTC) #2
Sven Panne
7 years ago (2013-12-09 10:14:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18276.

Powered by Google App Engine
This is Rietveld 408576698