Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: net/websockets/websocket_handshake_stream_base.h

Issue 105833003: Fail WebSocket channel when handshake fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_handshake_stream_base.h
diff --git a/net/websockets/websocket_handshake_stream_base.h b/net/websockets/websocket_handshake_stream_base.h
index 71d8321824fd1497c2bd4b8a01829c37d54cfd10..2a8f2ca48f6f2f10137c0f8786d13234454bbd9f 100644
--- a/net/websockets/websocket_handshake_stream_base.h
+++ b/net/websockets/websocket_handshake_stream_base.h
@@ -9,6 +9,8 @@
// Since net/http can be built without linking net/websockets code,
// this file must not introduce any link-time dependencies on websockets.
+#include <string>
+
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
@@ -64,6 +66,10 @@ class NET_EXPORT WebSocketHandshakeStreamBase : public HttpStreamBase {
// been called.
virtual scoped_ptr<WebSocketStream> Upgrade() = 0;
+ // Returns a string describes the connection failure detailed information.
Adam Rice 2013/12/09 07:41:12 s/describes/describing/ "detailed information" so
yhirano 2013/12/09 07:48:09 Done.
+ // Returns an empty string if there is no such failure.
Adam Rice 2013/12/09 07:41:12 The word "such" is not needed here.
yhirano 2013/12/09 07:48:09 Done.
+ virtual std::string FailureMessage() const = 0;
+
protected:
// As with the destructor, this must be inline.
WebSocketHandshakeStreamBase() {}

Powered by Google App Engine
This is Rietveld 408576698