net/websockets/websocket_channel.h - Issue 105833003: Fail WebSocket channel when handshake fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_channel.h

Issue 105833003: Fail WebSocket channel when handshake fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_channel.h

diff --git a/net/websockets/websocket_channel.h b/net/websockets/websocket_channel.h

index 61f191af97839b03fdc0c4cd3949cba92aef793a..721f71cf606425ef4a7ee7c276e21d294c3bd30f 100644

--- a/net/websockets/websocket_channel.h

+++ b/net/websockets/websocket_channel.h

@@ -153,7 +153,7 @@ class NET_EXPORT WebSocketChannel {

// Failure callback from WebSocketStream::CreateAndConnectStream(). Reports

// failure to the event interface. May delete |this|.

- void OnConnectFailure(uint16 websocket_error);

+ void OnConnectFailure(const std::string& message);

// Returns true if state_ is SEND_CLOSED, CLOSE_WAIT or CLOSED.

bool InClosingState() const;