Adding V8 api to get memory statistics of spaces in V8::Heap.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 5437 matching lines @@
 
 bool v8::V8::Dispose() {
   i::V8::TearDown();
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
   i::DisposeNatives();
 #endif
   return true;
 }
 
 
+class HeapSpacesStatistics {
+ public:
+  std::vector<HeapStatistics::SpaceStatistics>* SpacesStatistics() {
+    return &spaces_statistics_;
+  }
+
+ private:
+  std::vector<HeapStatistics::SpaceStatistics> spaces_statistics_;
+};
+
+
 HeapStatistics::HeapStatistics(): total_heap_size_(0),
                                   total_heap_size_executable_(0),
                                   total_physical_size_(0),
                                   used_heap_size_(0),
-                                  heap_size_limit_(0) { }
+                                  heap_size_limit_(0) {
+  spaces_statistics_ = new HeapSpacesStatistics();
+}
+
+
+HeapStatistics::~HeapStatistics() { free(spaces_statistics_); }

[rmcilroy, 2015/04/14 17:25:53]

You are using 'new' and 'free' which is wrong - you need to use 'delete' if you
are using 'new'. This is what asan is complaining about.

+
+
+std::vector<HeapStatistics::SpaceStatistics>*
+HeapStatistics::SpacesStatistics() {
+  return spaces_statistics_->SpacesStatistics();
+}
 
 
 bool v8::V8::InitializeICU(const char* icu_data_file) {
   return i::InitializeICU(icu_data_file);
 }
 
 
 const char* v8::V8::GetVersion() {
   return i::Version::GetVersion();
 }
@@ skipping 1516 matching lines @@
 
 void Isolate::GetHeapStatistics(HeapStatistics* heap_statistics) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   i::Heap* heap = isolate->heap();
   heap_statistics->total_heap_size_ = heap->CommittedMemory();
   heap_statistics->total_heap_size_executable_ =
       heap->CommittedMemoryExecutable();
   heap_statistics->total_physical_size_ = heap->CommittedPhysicalMemory();
   heap_statistics->used_heap_size_ = heap->SizeOfObjects();
   heap_statistics->heap_size_limit_ = heap->MaxReserved();
+
+  HeapStatistics::SpaceStatistics new_space_stats(
+      heap->GetSpaceName(i::NEW_SPACE),
+      heap->new_space()->CommittedMemory(),
+      heap->new_space()->Size(),
+      heap->new_space()->Available(),
+      heap->new_space()->CommittedPhysicalMemory());
+  heap_statistics->SpacesStatistics()->push_back(new_space_stats);
+
+  for (int space = i::FIRST_PAGED_SPACE; space < i::LAST_PAGED_SPACE; space++) {
+    HeapStatistics::SpaceStatistics space_stats(
+        heap->GetSpaceName(space),
+        heap->paged_space(space)->CommittedMemory(),
+        heap->paged_space(space)->SizeOfObjects(),
+        heap->paged_space(space)->Available(),
+        heap->paged_space(space)->CommittedPhysicalMemory());
+    heap_statistics->SpacesStatistics()->push_back(space_stats);
+  }
+
+  HeapStatistics::SpaceStatistics lo_space_stats(
+      heap->GetSpaceName(i::LO_SPACE),
+      heap->lo_space()->CommittedMemory(),
+      heap->lo_space()->SizeOfObjects(),
+      heap->lo_space()->Available(),
+      heap->lo_space()->CommittedPhysicalMemory());
+  heap_statistics->SpacesStatistics()->push_back(lo_space_stats);
 }
 
 
 void Isolate::GetStackSample(const RegisterState& state, void** frames,
                              size_t frames_limit, SampleInfo* sample_info) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   i::TickSample::GetStackSample(isolate, state, i::TickSample::kSkipCEntryFrame,
                                 frames, frames_limit, sample_info);
 }
 
@@ skipping 1100 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 } }  // namespace v8::internal