Source/core/html/HTMLSelectElement.cpp - Issue 1058243002: Implement support to consider <space> key as part of typeAhead searching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 1058243002: Implement support to consider <space> key as part of typeAhead searching. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch with new implementation Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/select/select-typeahead-with-spacekey-expected.txt ('k') | Source/core/html/forms/TypeAhead.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index d8eb4c116e4683ed3e38761b208b55c339c7dacf..fc0ed11c04a0a07b99ba054a63ca4e0d4829c972 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -1225,7 +1225,7 @@ bool HTMLSelectElement::shouldOpenPopupForKeyPressEvent(KeyboardEvent *event)

LayoutTheme& layoutTheme = LayoutTheme::theme();

int keyCode = event->keyCode();

- return ((layoutTheme.popsMenuBySpaceKey() && event->keyCode() == ' ')

+ return ((layoutTheme.popsMenuBySpaceKey() && event->keyCode() == ' ' && !m_typeAhead.hasActiveSession(event))

|| (layoutTheme.popsMenuByReturnKey() && keyCode == '\r'));

}

« no previous file with comments | « LayoutTests/fast/forms/select/select-typeahead-with-spacekey-expected.txt ('k') | Source/core/html/forms/TypeAhead.h » ('j') | no next file with comments »