Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1058243002: Implement support to consider <space> key as part of typeAhead searching. (Closed)

Created:
5 years, 8 months ago by Abhijeet Kandalkar Slow
Modified:
5 years, 8 months ago
Reviewers:
vivekg, eae
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement support to consider <space> key as part of typeAhead searching. Blink support special handling for <space> key to open menu-list item when it is selected. Typeahead searching in list item is reseted due to this feature. This patch adds an implementation to check whether current typeAhead sessions is active or not. If typeAhead session is active <space> is considered as part of search string othrwise open menu-list. Trying to match FF/IE behavior. BUG=473050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193280

Patch Set 1 #

Patch Set 2 : Patch with new implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -2 lines) Patch
A LayoutTests/fast/forms/select/select-typeahead-with-spacekey.html View 1 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select/select-typeahead-with-spacekey-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TypeAhead.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TypeAhead.cpp View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Abhijeet Kandalkar Slow
Please review patch.
5 years, 8 months ago (2015-04-03 08:06:44 UTC) #2
eae
This doesn't seem like the right fix, we want space to open the menu as ...
5 years, 8 months ago (2015-04-03 17:13:29 UTC) #3
Abhijeet Kandalkar Slow
On 2015/04/03 17:13:29, eae wrote: > This doesn't seem like the right fix, we want ...
5 years, 8 months ago (2015-04-05 06:53:27 UTC) #4
eae
Much better thank you LGTM
5 years, 8 months ago (2015-04-07 14:47:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058243002/20001
5 years, 8 months ago (2015-04-07 15:17:19 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 16:34:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193280

Powered by Google App Engine
This is Rietveld 408576698