Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 105823014: Add Windows on Swarm usage for the Chromium CQ. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, csharp, Vadim Sh.
Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue.git@master
Visibility:
Public.

Description

Add Windows on Swarm usage for the Chromium CQ. It took a long time but Windows is now stable enough to be used by the CQ. Fallbacks are still using non-Swarm jobs as a safety precaution. Linux was added in r232775. OSX was added in r234506. R=phajdan.jr@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241387

Patch Set 1 #

Patch Set 2 : Riiiiietveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M projects.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years ago (2013-12-17 20:53:55 UTC) #1
M-A Ruel
Paweł, when you wake up and if agree to lgtm this CL, can you restart ...
7 years ago (2013-12-17 21:40:04 UTC) #2
ghost stip (do not use)
lgtm
7 years ago (2013-12-17 21:53:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/105823014/20001
7 years ago (2013-12-17 22:23:27 UTC) #4
commit-bot: I haz the power
Change committed as 241387
7 years ago (2013-12-17 22:24:16 UTC) #5
Paweł Hajdan Jr.
7 years ago (2013-12-20 12:44:30 UTC) #6
Message was sent while issue was closed.
On 2013/12/17 21:40:04, M-A Ruel wrote:
> Paweł, when you wake up and if agree to lgtm this CL, can you restart the CQ
> too? I will wake up a few hours later and will look at the recent CQ try jobs
to
> monitor any anomality.
>
http://build.chromium.org/p/tryserver.chromium/builders/win_swarm_triggered?n...
> got in a pretty good state now.
> 
> Thanks,
> 
> M-A

I'm fine with the change.

Given there is a rotation of troopers based primarily in MTV, I wouldn't like to
interfere with that without prior approval. Feel free to send an e-mail to
chrome-troopers asking for a restart, and mention that if there are no
objections you'd like me to do the CQ restart.

Powered by Google App Engine
This is Rietveld 408576698