Issue 105823005: Remove TreatNullAs=NullString for URLUtils.href

Issue 105823005: Remove TreatNullAs=NullString for URLUtils.href (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews)

CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for URLUtils.href http://url.spec.whatwg.org/#urlutils The updated element-attribute-js-null tests pass in Firefox Nightly, IE11 Release Preview and Opera 12.16. No other browser passes the URL.href test, because Firefox throws when setting a non-valid URL, while IE and Opera don't even support the URL constructor. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163294

Patch Set 1 #

Patch Set 2 : force rebuild #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -11 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/domurl/url-href.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/domurl/url-href-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/URL.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/URLUtils.idl	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/html/HTMLAnchorElement.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLAreaElement.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerLocation.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Erik, it looks like the trybots are failing because of http://crbug.com/307023 Will I have to ...

7 years ago (2013-12-05 15:11:30 UTC) #1

arv (Not doing code reviews)

LGTM Here are the places you need to add a whitespace or some other crap: ...

7 years ago (2013-12-05 16:23:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/105823005/20001

7 years ago (2013-12-05 20:30:36 UTC) #3

Message was sent while issue was closed.

Change committed as 163294

Expand Messages | Collapse Messages