Add support for not owning distilled WebContents

Add support for not owning distilled WebContents

Currently the SourcePageHandleWebContents holds a scoped_ptr<WebContents>,
which means that when distillation of the source page is finished, the
WebContents will be destroyed. This makes it hard to distill the contents
from one WebContents, and view the result in another.

This CL makes the SourcePageHandleWebContents only optionally own the
WebContents by taking in a raw pointer an a bool flag of whether it should
own it or not.

In the current chrome-level API DistillCurrentPageAndView the old behavior
is kept, and the source WebContents is destroyed when distillation finishes.

In addition, this CL adds a new chrome-level API DistillAndView(...), where
the caller passes in two WebContents, one for the source page, and one for
where the caller wants to view the distilled content. The distiller code does
in this case not take ownership of any of these.

BUG=None
TEST=browser_tests,components_browsertests

Committed: https://crrev.com/405029be4a4dfe081a2c4293b403c3c47b741d80
Cr-Commit-Position: refs/heads/master@{#329544}

[nyquist, 2015-04-30 22:51:24]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 22:52:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058193002/100001

[nyquist, 2015-04-30 23:06:11]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2015-04-30 23:06:23]

nyquist@chromium.org changed reviewers:
+ cjhopman@chromium.org

[nyquist, 2015-04-30 23:06:24]

cjhopman: PTAL

[commit-bot: I haz the power, 2015-04-30 23:10:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058193002/120001

[commit-bot: I haz the power, 2015-05-01 01:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 01:34:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nyquist, 2015-05-12 01:01:26]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2015-05-12 01:01:40]

cjhopman: PTAL

[commit-bot: I haz the power, 2015-05-12 01:04:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058193002/140001

[commit-bot: I haz the power, 2015-05-12 02:27:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 02:27:52]

Dry run: This issue passed the CQ dry run.

[cjhopman, 2015-05-12 21:18:42]

lgtm

https://codereview.chromium.org/1058193002/diff/140001/chrome/browser/dom_dis...
File chrome/browser/dom_distiller/tab_utils.cc (right):

https://codereview.chromium.org/1058193002/diff/140001/chrome/browser/dom_dis...
chrome/browser/dom_distiller/tab_utils.cc:126: new
SourcePageHandleWebContents(web_contents, owned));
If you wrap this in the sourcepagehandle at the beginning of the function, you
don't need the explicit delete in the early return.

Or maybe, this function could just take a scoped_ptr<SPHWC> and then it doesn't
ever care about owned vs unowned

[nyquist, 2015-05-12 23:40:59]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2015-05-12 23:41:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
cjhopman@chromium.org
Link to the patchset: https://codereview.chromium.org/1058193002/#ps180001
(title: "Fix issues.")

[commit-bot: I haz the power, 2015-05-12 23:41:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058193002/180001

[nyquist, 2015-05-13 00:06:52]

https://codereview.chromium.org/1058193002/diff/140001/chrome/browser/dom_dis...
File chrome/browser/dom_distiller/tab_utils.cc (right):

https://codereview.chromium.org/1058193002/diff/140001/chrome/browser/dom_dis...
chrome/browser/dom_distiller/tab_utils.cc:126: new
SourcePageHandleWebContents(web_contents, owned));
On 2015/05/12 21:18:42, cjhopman wrote:
> If you wrap this in the sourcepagehandle at the beginning of the function, you
> don't need the explicit delete in the early return.
> 
> Or maybe, this function could just take a scoped_ptr<SPHWC> and then it
doesn't
> ever care about owned vs unowned

Done.

[commit-bot: I haz the power, 2015-05-13 00:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 00:36:23]

Dry run: This issue passed the CQ dry run.

[nyquist, 2015-05-13 00:39:32]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2015-05-13 00:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058193002/180001

[commit-bot: I haz the power, 2015-05-13 00:46:37]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-05-13 00:47:36]

Patchset 10 (id:??) landed as
https://crrev.com/405029be4a4dfe081a2c4293b403c3c47b741d80
Cr-Commit-Position: refs/heads/master@{#329544}