Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1058173002: Revert of Try ARMv7 and NEON for Daisy. (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chromium.org/1054233002/) Reason for revert: whatever compiler we're using can't handle array subscripts for neon vectors Original issue's description: > Try ARMv7 and NEON for Daisy. > > I think Daisy's color order problems are in non-NEON ARM assembly. > NEON might actually be fine. > > BUG=skia:1843 > > Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1843 Committed: https://skia.googlesource.com/skia/+/fb806dd27d93d09a1aedac6c4666f4424c7d9c7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M platform_tools/chromeos/bin/chromeos_setup.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Try ARMv7 and NEON for Daisy.
5 years, 8 months ago (2015-04-02 22:40:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058173002/1
5 years, 8 months ago (2015-04-02 22:41:21 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 22:41:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb806dd27d93d09a1aedac6c4666f4424c7d9c7d

Powered by Google App Engine
This is Rietveld 408576698