Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1058143004: Chromecast: moves ConnectivityChecker to the IO thread. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: moves ConnectivityChecker to the IO thread. R=derekjchow@chromium.org,byungchul@chromium.org,lcwu@chromium.org BUG=476713 Committed: https://crrev.com/195e961645fb951a64213a2b4233006f27e88272 Cr-Commit-Position: refs/heads/master@{#325446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
gunsch
5 years, 8 months ago (2015-04-16 00:41:31 UTC) #1
derekjchow1
On 2015/04/16 00:41:31, gunsch wrote: LGTM
5 years, 8 months ago (2015-04-16 00:42:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058143004/1
5 years, 8 months ago (2015-04-16 00:46:09 UTC) #4
byungchul
lgtm
5 years, 8 months ago (2015-04-16 00:51:27 UTC) #5
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-16 01:05:55 UTC) #7
lcwu1
lgtm
5 years, 8 months ago (2015-04-16 06:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058143004/1
5 years, 8 months ago (2015-04-16 15:11:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 15:11:53 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 15:12:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/195e961645fb951a64213a2b4233006f27e88272
Cr-Commit-Position: refs/heads/master@{#325446}

Powered by Google App Engine
This is Rietveld 408576698