Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105813013: Adds views::corewm::WMState to install common state (Closed)

Created:
7 years ago by sky
Modified:
7 years ago
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, sadrul, ben+ash_chromium.org, kalyank, ben+views_chromium.org, ben+corewm_chromium.org
Visibility:
Public.

Description

Adds views::corewm::WMState to install common state I'm going to need to install a another singleton client for transients. Rather than touch all places to explicitly set n clients I'm creating Environment to centralize common setup and teardown. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242126

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : WMState #

Patch Set 4 : fix viewseventtestbase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -55 lines) Patch
M ash/shell/content_client/shell_browser_main_parts.h View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ash/shell/shell_main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 4 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M ui/aura/client/window_stacking_client.h View 1 chunk +9 lines, -4 lines 0 comments Download
M ui/aura/client/window_stacking_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M ui/views/corewm/shadow_controller_unittest.cc View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M ui/views/corewm/transient_window_stacking_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/transient_window_stacking_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
A ui/views/corewm/wm_state.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A ui/views/corewm/wm_state.cc View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
7 years ago (2013-12-19 18:45:13 UTC) #1
Ben Goodger (Google)
LGTM, but call it WMState
7 years ago (2013-12-19 19:03:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/105813013/40001
7 years ago (2013-12-19 19:30:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) app_list_unittests, aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, ...
7 years ago (2013-12-19 20:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/105813013/60001
7 years ago (2013-12-19 20:42:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108267
7 years ago (2013-12-20 02:24:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/105813013/60001
7 years ago (2013-12-20 03:18:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108432
7 years ago (2013-12-20 10:29:03 UTC) #8
sky
7 years ago (2013-12-20 17:55:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 manually as r242126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698