extensions/browser/api/guest_view/web_view/web_view_internal_api.cc - Issue 1058113002: Implement <webview>.addContentScript/removeContentScript API [3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

Issue 1058113002: Implement <webview>.addContentScript/removeContentScript API [3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webui_api_1

Patch Set: nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/webview_content_script_test.js ('K') | « chrome/test/data/webui/webview_execute_script_test.js ('k') | extensions/common/api/web_view_internal.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

index ff794e7e091b03cfbe9a50e783f0471e97d54659..3f93f798376d7dee883b564ad36432d7f3726484 100644

--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

@@ -164,6 +164,15 @@ bool Parse(const ContentScriptDetails& script_value,

}

+ // code:

+ if (script_value.code) {

+ const std::string& code = *(script_value.code.get());

+ extensions::UserScript::File file((base::FilePath()), (base::FilePath()),

+ GURL());

+ file.set_content(code);

+ script->js_scripts().push_back(file);

+ }

// all_frames:

if (script_value.all_frames) {

script->set_match_all_frames(*(script_value.all_frames));