Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/common/api/web_view_internal.json

Issue 1058113002: Implement <webview>.addContentScript/removeContentScript API [3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webui_api_1
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/web_view_internal.json
diff --git a/extensions/common/api/web_view_internal.json b/extensions/common/api/web_view_internal.json
index bb85dabf9a964b2058b8e2d117f0acf4e64f00bd..bae49bd6034a9f3523cc598ee6e396215eaf4667 100644
--- a/extensions/common/api/web_view_internal.json
+++ b/extensions/common/api/web_view_internal.json
@@ -120,6 +120,12 @@
"optional": true,
"description": "The list of JavaScript files to be injected into matching pages. These are injected in the order they appear in this array."
},
+ "code": {
+ "type": "array",
xiyuan 2015/04/07 20:35:02 Shouldn't a string be sufficient?
Xi Han 2015/04/07 20:43:10 I just make the "code" be consistent with "js" or
xiyuan 2015/04/07 21:13:14 "js"/"css" refers to files and it makes sense to h
Xi Han 2015/04/08 14:47:40 Your point makes sense to me. Updated to a string:
+ "items": { "type": "string"},
+ "optional": true,
+ "description": "The list of JavaScript code to be injected into matching pages. These are injected in the order they appear in this array."
+ },
"run_at": {
"type": "string",
"optional": true,

Powered by Google App Engine
This is Rietveld 408576698