Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058013006: Chromecast: make CAST_IS_DEBUG_BUILD to macro CAST_IS_DEBUG_BUILD(). (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@media-drm-delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: make CAST_IS_DEBUG_BUILD to macro CAST_IS_DEBUG_BUILD(). Also allow enabling it via a GYP flag. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/b63b533c2ef5ca96e5208a292dadfb264f217bf7 Cr-Commit-Position: refs/heads/master@{#325281}

Patch Set 1 #

Patch Set 2 : rename bit #

Total comments: 2

Patch Set 3 : updates version.h.in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chromecast/chromecast.gyp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/common/version.h.in View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromecast/crash/android/cast_crash_reporter_client_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/crash/android/crash_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 8 months ago (2015-04-15 01:16:56 UTC) #1
lcwu1
https://codereview.chromium.org/1058013006/diff/20001/chromecast/common/version.h.in File chromecast/common/version.h.in (right): https://codereview.chromium.org/1058013006/diff/20001/chromecast/common/version.h.in#newcode18 chromecast/common/version.h.in:18: #endif Curious why you have to change to use ...
5 years, 8 months ago (2015-04-15 17:10:15 UTC) #2
gunsch
https://codereview.chromium.org/1058013006/diff/20001/chromecast/common/version.h.in File chromecast/common/version.h.in (right): https://codereview.chromium.org/1058013006/diff/20001/chromecast/common/version.h.in#newcode18 chromecast/common/version.h.in:18: #endif On 2015/04/15 17:10:14, lcwu1 wrote: > Curious why ...
5 years, 8 months ago (2015-04-15 17:45:53 UTC) #3
lcwu1
lgtm
5 years, 8 months ago (2015-04-15 17:59:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058013006/40001
5 years, 8 months ago (2015-04-15 18:07:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-15 18:40:56 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 18:46:47 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b63b533c2ef5ca96e5208a292dadfb264f217bf7
Cr-Commit-Position: refs/heads/master@{#325281}

Powered by Google App Engine
This is Rietveld 408576698