Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1058013002: New binary for PeImageReaderCertificateTest. (Closed)

Created:
5 years, 8 months ago by grt (UTC plus 2)
Modified:
5 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New binary for PeImageReaderCertificateTest. BUG=462584 R=mattm@chromium.org TBR=mattm@chromium.org Committed: https://crrev.com/eb2faeea45dbdc449c12e5e6ee1d3a03093b2efb Cr-Commit-Position: refs/heads/master@{#323578}

Patch Set 1 #

Patch Set 2 : chmod +x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/data/safe_browsing/download_protection/README View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/test/data/safe_browsing/download_protection/signed_twice.exe View 1 Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
grt (UTC plus 2)
I will "git cl land" this after you approve https://codereview.chromium.org/1047693002/ to get the new binary ...
5 years, 8 months ago (2015-04-02 17:54:25 UTC) #2
mattm
lgtm
5 years, 8 months ago (2015-04-02 21:39:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058013002/20001
5 years, 8 months ago (2015-04-03 00:55:33 UTC) #5
grt (UTC plus 2)
Committed patchset #2 (id:20001) manually as eb2faeea45dbdc449c12e5e6ee1d3a03093b2efb (presubmit successful).
5 years, 8 months ago (2015-04-03 02:30:53 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:29:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb2faeea45dbdc449c12e5e6ee1d3a03093b2efb
Cr-Commit-Position: refs/heads/master@{#323578}

Powered by Google App Engine
This is Rietveld 408576698