Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057993003: gn-mode: Add matching for variables in strings. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn-mode: Add matching for variables in strings. This adds font-lock regexps to match the three different embedded variable syntaxes. I added faces for these constructs, and reorganized variables so they're now all part of a group for custom. BUG=none Committed: https://crrev.com/3e301cc25cf6f62dfd3b7df36a62db87a7292926 Cr-Commit-Position: refs/heads/master@{#324074}

Patch Set 1 #

Patch Set 2 : Inherited from the wrong thing. #

Patch Set 3 : Also add an imenu indexer. #

Patch Set 4 : Specify the custom :group for gn-mode. #

Patch Set 5 : Move to gn-mode.el and add standard header. #

Total comments: 4

Patch Set 6 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -106 lines) Patch
M tools/gn/misc/emacs/gn.el View 1 2 3 4 1 chunk +0 lines, -94 lines 0 comments Download
A + tools/gn/misc/emacs/gn-mode.el View 1 2 3 4 5 3 chunks +65 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Elliot Glaysher
5 years, 8 months ago (2015-04-02 19:57:54 UTC) #2
Nico
lgtm https://codereview.chromium.org/1057993003/diff/70001/tools/gn/misc/emacs/gn-mode.el File tools/gn/misc/emacs/gn-mode.el (right): https://codereview.chromium.org/1057993003/diff/70001/tools/gn/misc/emacs/gn-mode.el#newcode92 tools/gn/misc/emacs/gn-mode.el:92: font-lock-variable-name-face) I like these comments. https://codereview.chromium.org/1057993003/diff/70001/tools/gn/misc/emacs/gn-mode.el#newcode102 tools/gn/misc/emacs/gn-mode.el:102: ;; ...
5 years, 8 months ago (2015-04-04 20:30:35 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/1057993003/diff/70001/tools/gn/misc/emacs/gn-mode.el File tools/gn/misc/emacs/gn-mode.el (right): https://codereview.chromium.org/1057993003/diff/70001/tools/gn/misc/emacs/gn-mode.el#newcode102 tools/gn/misc/emacs/gn-mode.el:102: ;; {{variables_like_this}} On 2015/04/04 20:30:34, Nico wrote: > Huh, ...
5 years, 8 months ago (2015-04-07 18:01:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057993003/90001
5 years, 8 months ago (2015-04-07 18:02:15 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 8 months ago (2015-04-07 18:28:23 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:29:13 UTC) #9
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/3e301cc25cf6f62dfd3b7df36a62db87a7292926
Cr-Commit-Position: refs/heads/master@{#324074}

Powered by Google App Engine
This is Rietveld 408576698