Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057993002: Remove duplicate MoveReadyDelayedTasksToIncomingQueueLocked (Closed)

Created:
5 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate MoveReadyDelayedTasksToIncomingQueueLocked TaskQueue::UpdateWorkQueue had a duplicate call to MoveReadyDelayedTasksToIncomingQueueLocked. That's not intended but benign. This patch removes it. BUG= Committed: https://crrev.com/d3f2f69aed2bc18605ac72582a5b5883b2d5beca Cr-Commit-Position: refs/heads/master@{#324217}

Patch Set 1 #

Patch Set 2 : Fix diffbase #

Total comments: 2

Patch Set 3 : Move the call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/child/scheduler/task_queue_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-07 12:14:06 UTC) #2
Sami
https://codereview.chromium.org/1057993002/diff/20001/content/child/scheduler/task_queue_manager.cc File content/child/scheduler/task_queue_manager.cc (right): https://codereview.chromium.org/1057993002/diff/20001/content/child/scheduler/task_queue_manager.cc#newcode306 content/child/scheduler/task_queue_manager.cc:306: MoveReadyDelayedTasksToIncomingQueueLocked(lazy_now); Should we do this after the pump check ...
5 years, 8 months ago (2015-04-07 12:41:30 UTC) #3
alex clarke (OOO till 29th)
https://codereview.chromium.org/1057993002/diff/20001/content/child/scheduler/task_queue_manager.cc File content/child/scheduler/task_queue_manager.cc (right): https://codereview.chromium.org/1057993002/diff/20001/content/child/scheduler/task_queue_manager.cc#newcode306 content/child/scheduler/task_queue_manager.cc:306: MoveReadyDelayedTasksToIncomingQueueLocked(lazy_now); On 2015/04/07 12:41:30, Sami wrote: > Should we ...
5 years, 8 months ago (2015-04-08 10:00:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057993002/40001
5 years, 8 months ago (2015-04-08 10:01:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54777)
5 years, 8 months ago (2015-04-08 10:18:28 UTC) #8
Sami
lgtm.
5 years, 8 months ago (2015-04-08 10:38:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057993002/40001
5 years, 8 months ago (2015-04-08 10:40:45 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 12:09:07 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 12:10:04 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d3f2f69aed2bc18605ac72582a5b5883b2d5beca
Cr-Commit-Position: refs/heads/master@{#324217}

Powered by Google App Engine
This is Rietveld 408576698