Refactor PDFium python test utilities.

Refactor PDFium python test utilities.

Extract a common portions for determining suppressions and comparing pngs.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/6ce87f3e283a2cf44cacbcea7f0dc72633682b5b

[Tom Sepez, 2015-04-02 20:42:58]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-04-02 20:42:58]

Lei, please review.

[Lei Zhang, 2015-04-02 23:16:20]

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer.py
File testing/tools/pngdiffer.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:13: self.actual_template = '.pdf.%d.png'
this can be a class constant

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:43: # Testing.
Other python projects within the chromium-sphere puts tests for foo.py in
foo_test.py.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:45: if sys.platform.startswith('linux'):
This can go in to common.py since we use it everywhere.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/run_corpu...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/run_corpu...
testing/tools/run_corpus_tests.py:86: from suppressor import Suppressor
from x import y, only where y is a module.

https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Impor...

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/suppresso...
testing/tools/suppressor.py:11: self.suppressions_filename = 'SUPPRESSIONS'
class constant

[Tom Sepez, 2015-04-03 18:13:15]

Lei, please re-review. I put much of the directory work into a new class in the
new common.py file.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer.py
File testing/tools/pngdiffer.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:13: self.actual_template = '.pdf.%d.png'
On 2015/04/02 23:16:20, Lei Zhang wrote:
> this can be a class constant

Done.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:43: # Testing.
On 2015/04/02 23:16:20, Lei Zhang wrote:
> Other python projects within the chromium-sphere puts tests for foo.py in
> foo_test.py.

Comment is misleading.  This makes a command-line utility out of the module, but
its only used by the developer for his own ... testing. 
I've removed this as the marginal benefit isn't worth the cost of code.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/pngdiffer...
testing/tools/pngdiffer.py:45: if sys.platform.startswith('linux'):
On 2015/04/02 23:16:20, Lei Zhang wrote:
> This can go in to common.py since we use it everywhere.

Done.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/run_corpu...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/run_corpu...
testing/tools/run_corpus_tests.py:86: from suppressor import Suppressor
On 2015/04/02 23:16:20, Lei Zhang wrote:
> from x import y, only where y is a module.
> 
>
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Impor...

Done.

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1057983003/diff/20001/testing/tools/suppresso...
testing/tools/suppressor.py:11: self.suppressions_filename = 'SUPPRESSIONS'
On 2015/04/02 23:16:20, Lei Zhang wrote:
> class constant

Done.

[Lei Zhang, 2015-04-03 19:50:27]

lgtm

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/common.py
File testing/tools/common.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/common.py...
testing/tools/common.py:23: def __init__(self, build_type):
You may want to add a comment to explain what build_type is. It could mean
standalone vs chromium to the reader, but I think here it means Debug or
Release, right?

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/run_corpu...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/run_corpu...
testing/tools/run_corpus_tests.py:6: import common
Group local imports separately:

sys1
sys2

local1
local2

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/suppresso...
testing/tools/suppressor.py:8: import sys
not used

[Tom Sepez, 2015-04-03 20:19:51]

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/common.py
File testing/tools/common.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/common.py...
testing/tools/common.py:23: def __init__(self, build_type):
On 2015/04/03 19:50:27, Lei Zhang wrote:
> You may want to add a comment to explain what build_type is. It could mean
> standalone vs chromium to the reader, but I think here it means Debug or
> Release, right?

Done.

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/run_corpu...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/run_corpu...
testing/tools/run_corpus_tests.py:6: import common
On 2015/04/03 19:50:27, Lei Zhang wrote:
> Group local imports separately:
> 
> sys1
> sys2
> 
> local1
> local2

Done.

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1057983003/diff/80001/testing/tools/suppresso...
testing/tools/suppressor.py:8: import sys
On 2015/04/03 19:50:27, Lei Zhang wrote:
> not used

Done.

[Tom Sepez, 2015-04-03 20:21:59]

Committed patchset #7 (id:120001) manually as
6ce87f3e283a2cf44cacbcea7f0dc72633682b5b (presubmit successful).