Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1057983002: Link HttpStreams to QuicSessions in net-internals. (Closed)

Created:
5 years, 8 months ago by Ryan Hamilton
Modified:
5 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link HttpStreams to QuicSessions in net-internals. Committed: https://crrev.com/98f59d0df704b0385f2cdda6cd9b99bc18627fe1 Cr-Commit-Position: refs/heads/master@{#323586}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/log/net_log_event_type_list.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Ryan Hamilton
Hi Eric, I'm not sure that I did this the right way, so I'd appreciate ...
5 years, 8 months ago (2015-04-02 16:59:47 UTC) #2
eroman
lgtm
5 years, 8 months ago (2015-04-02 17:07:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057983002/1
5 years, 8 months ago (2015-04-02 17:08:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/11346) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-02 17:14:58 UTC) #7
eroman
Heh you have me to thank for this, I moved the NetLog files from net/base ...
5 years, 8 months ago (2015-04-02 17:15:48 UTC) #8
eroman
(https://chromium.googlesource.com/chromium/src.git/+/87c53d6fe5c6ef6dc3adb9c358f54be3d90b050d)
5 years, 8 months ago (2015-04-02 17:16:35 UTC) #9
Ryan Hamilton
On 2015/04/02 17:15:48, eroman wrote: > Heh you have me to thank for this, I ...
5 years, 8 months ago (2015-04-02 17:17:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057983002/20001
5 years, 8 months ago (2015-04-02 17:57:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 04:57:44 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:30:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98f59d0df704b0385f2cdda6cd9b99bc18627fe1
Cr-Commit-Position: refs/heads/master@{#323586}

Powered by Google App Engine
This is Rietveld 408576698