Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 1057963003: Remove fallback attempt to set outerHtml when removing corrupt nodes, it won't work anyway (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 2b7006bd5a81f4be99f61e711e7acc6f9625cd41..e780d2e8a365a6510fb9196c8aaea17f44d9507b 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -13273,7 +13273,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
element.lastChild !== childNodes[childNodes.length -1]) {
return true;
}
- if (element.children) {
+ if (element.children) { // On Safari, children can apparently be null.
if (!((element.children instanceof HTMLCollection) ||
(element.children instanceof NodeList))) {
return true;
@@ -40822,11 +40822,7 @@ class _ValidatingTreeSanitizer implements NodeTreeSanitizer {
if (parent == null) {
node.remove();
} else {
- try {
- parent._removeChild(node);
- } catch (e) {
- node.outerHtml = '';
- }
+ parent._removeChild(node);
}
}
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698