Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: Source/core/dom/Position.cpp

Issue 1057953002: Make flexibleBox visible position cadidate only where it is editable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use helvetica if possible. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/mac/fast/events/drag-in-flex-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Position.cpp
diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp
index 699caff565faebf728692d8584433879feb4f063..54c9d4fb9b6b3b77433e4047e0bcf4f5b2c66705 100644
--- a/Source/core/dom/Position.cpp
+++ b/Source/core/dom/Position.cpp
@@ -891,7 +891,7 @@ bool Position::isCandidate() const
if (isHTMLHtmlElement(*m_anchorNode))
return false;
- if (renderer->isLayoutBlockFlow() || renderer->isFlexibleBox() || renderer->isLayoutGrid()) {
+ if (renderer->isLayoutBlockFlow() || (renderer->isFlexibleBox() && m_anchorNode->hasEditableStyle()) || renderer->isLayoutGrid()) {
pdr. 2015/04/06 18:25:46 I'm not an expert in this area but this fix looks
if (toLayoutBlock(renderer)->logicalHeight() || isHTMLBodyElement(*m_anchorNode)) {
if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(renderer))
return atFirstEditingPositionForNode() && !Position::nodeIsUserSelectNone(deprecatedNode());
« no previous file with comments | « LayoutTests/platform/mac/fast/events/drag-in-flex-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698