[iOS] Upstream //ios/chrome/browser/memory

[iOS] Upstream //ios/chrome/browser/memory

Committed: https://crrev.com/a7b5e669bd7b9cf14a5b409d39d6673ea512f2f2
Cr-Commit-Position: refs/heads/master@{#324216}

[droger, 2015-04-02 15:43:05]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-04-03 08:21:49]

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
File ios/chrome/browser/memory/memory_debugger.mm (right):

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:94: // |index| is used to calculate
the veritical position of each element in
nit: s/veritical/vertical/

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:117: // stable builds.
nit: s/stable/official/

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:142: // stable builds.
nit: s/stable/official/

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:412: // TODO(lliabraa): Correctly
handle rotation (crbug/368263).
nit: Remove this comment as the bug has been marked as WontFix

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:487: _bloat.reset(kNumberOfBytes ?
(uint8*)malloc(kNumberOfBytes) : NULL);
style: C-style cast are forbidden

Moreover _bloat is a scoped_ptr<uint8> so the destructor will use delete, not
free. This is undefined behaviour (mixing new/delete & malloc/free). Please
change to (which does not require a cast):

_bloat.reset(kNumberOfBytes ? new uint8[kNumberOfBytes] : nullptr);

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_debugger.mm:531: // stable builds.
nit: s/stable/official/

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
File ios/chrome/browser/memory/memory_metrics.cc (right):

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_metrics.cc:34: (host_info_t)&vmstat, &count);
style: C-style cast are forbidden, use static_cast<>

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_metrics.cc:59: VM_REGION_EXTENDED_INFO,
(vm_region_info_t)&info,
style: C-style cast are forbidden, use static_cast<>

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_metrics.cc:78: (task_info_t)&task_vm_info,
&count);
style: C-style cast are forbidden, use static_cast<>

[droger, 2015-04-03 09:20:22]

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
File ios/chrome/browser/memory/memory_metrics.cc (right):

https://codereview.chromium.org/1057933002/diff/1/ios/chrome/browser/memory/m...
ios/chrome/browser/memory/memory_metrics.cc:34: (host_info_t)&vmstat, &count);
On 2015/04/03 08:21:49, sdefresne wrote:
> style: C-style cast are forbidden, use static_cast<>

I had to use reinterpret_cast everywhere, as the parameters of the functions are
defined as int*.

[droger, 2015-04-08 07:37:43]

ping

[sdefresne, 2015-04-08 07:42:50]

lgtm

https://codereview.chromium.org/1057933002/diff/20001/ios/chrome/browser/memo...
File ios/chrome/browser/memory/memory_debugger.h (right):

https://codereview.chromium.org/1057933002/diff/20001/ios/chrome/browser/memo...
ios/chrome/browser/memory/memory_debugger.h:11: // tools ((e.g. trigger memory
warning) to help investigate memory issues and
nit: only one (

[droger, 2015-04-08 11:35:53]

Thanks for the review.

[droger, 2015-04-08 11:35:56]

The CQ bit was checked by droger@chromium.org

[droger, 2015-04-08 11:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1057933002/#ps40001
(title: "Remove extra bracket")

[commit-bot: I haz the power, 2015-04-08 11:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057933002/40001

[commit-bot: I haz the power, 2015-04-08 11:59:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-08 12:00:55]

Patchset 3 (id:??) landed as
https://crrev.com/a7b5e669bd7b9cf14a5b409d39d6673ea512f2f2
Cr-Commit-Position: refs/heads/master@{#324216}