android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1057923007: Don't use mContentViewCore after WebView has been destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1057923007: Don't use mContentViewCore after WebView has been destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index b7603afd72f45f1d9c2d88889fc4d9633fe74f99..59ede168dad6c84d48d828a2c23672e8bec5677a 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -759,7 +759,7 @@ public class AwContents implements SmartClipProvider,

* Called when the app has requested to exit fullscreen.

void requestExitFullscreen() {

- mContentViewCore.getWebContents().exitFullscreen();

+ if (!isDestroyed()) mContentViewCore.getWebContents().exitFullscreen();

}

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »