Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1057913003: Introduce HttpStreamFactoryImpl::Job::IsAlternate. (Closed)

Created:
5 years, 8 months ago by Bence
Modified:
5 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce HttpStreamFactoryImpl::Job::IsAlternate. This is refactoring/code cleanup, no functional change intended. This relies on the class invariant that (a HttpStreamFactoryImpl::Job instance represents an alternate job) iff (original_url_ is set) iff (alternative_service_ is initialized). Patch Set 1: Introduce Job::IsAlternate(). Patch Set 2: Change IsAlternate to rely on |alternative_service_| instead. Patch Set 3: Change |orginal_url_| type from scoped_ptr<GURL> to GURL. Patch Set 4: Fix typo in ReportJobSucceededForRequest. Patch Set 5: s/MaybeMarkAlternateProtocolBroken/MaybeMarkAlternativeServiceBroken/g BUG=392575 Committed: https://crrev.com/52d6e54d69b063b4672ace69a94fe513d806d51b Cr-Commit-Position: refs/heads/master@{#323736}

Patch Set 1 #

Patch Set 2 : Change IsAlternate to rely on |alternative_service_| instead. #

Patch Set 3 : Change |original_url_| type from scoped_ptr<GURL> to GURL. #

Patch Set 4 : Fix typo in ReportJobSucceededForRequest. #

Patch Set 5 : s/MaybeMarkAlternateProtocolBroken/MaybeMarkAlternativeServiceBroken/g #

Total comments: 8

Patch Set 6 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M net/http/http_stream_factory_impl_job.h View 1 2 3 4 5 4 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 4 5 10 chunks +23 lines, -20 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 8 months ago (2015-04-02 20:03:26 UTC) #2
Ryan Hamilton
lgtm Great cleanup! Well done. https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.cc#newcode823 net/http/http_stream_factory_impl_job.cc:823: bool want_spdy_over_npn = IsAlternate(); ...
5 years, 8 months ago (2015-04-03 00:13:25 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.h File net/http/http_stream_factory_impl_job.h (right): https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.h#newcode277 net/http/http_stream_factory_impl_job.h:277: GURL original_url_; On 2015/04/03 00:13:25, Ryan Hamilton wrote: > ...
5 years, 8 months ago (2015-04-03 00:20:32 UTC) #4
Bence
Thanks. https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/1057913003/diff/80001/net/http/http_stream_factory_impl_job.cc#newcode823 net/http/http_stream_factory_impl_job.cc:823: bool want_spdy_over_npn = IsAlternate(); On 2015/04/03 00:13:25, Ryan ...
5 years, 8 months ago (2015-04-03 11:05:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057913003/100001
5 years, 8 months ago (2015-04-03 11:06:25 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-03 13:05:37 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:37:27 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/52d6e54d69b063b4672ace69a94fe513d806d51b
Cr-Commit-Position: refs/heads/master@{#323736}

Powered by Google App Engine
This is Rietveld 408576698