Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1057883004: X87: Ensure object literal element boilerplates aren't modified. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Ensure object literal element boilerplates aren't modified. port 7c347c545e33d279b5aa476e754a5358201be846 (r27511) original commit message: A bug allows JSObject literals with elements to have the elements in the boilerplate modified. BUG= Committed: https://crrev.com/9bf64f7e614d55766385c122a99c1e7070cd9d2b Cr-Commit-Position: refs/heads/master@{#27595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M src/x87/full-codegen-x87.cc View 6 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-03 02:04:55 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-03 02:30:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057883004/1
5 years, 8 months ago (2015-04-03 02:32:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 02:55:05 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 02:55:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bf64f7e614d55766385c122a99c1e7070cd9d2b
Cr-Commit-Position: refs/heads/master@{#27595}

Powered by Google App Engine
This is Rietveld 408576698