Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: site/dev/sheriffing/index.md

Issue 1057883002: Add documentation for tree sheriffs (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Initial upload Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « site/dev/METADATA ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 Tree Sheriffs Documentation
2 ===========================
3
4 ### Contents ###
5
6 * [What does a sheriff do?](#what_is_a_sheriff)
7 + [Skia tree](#skia_tree)
8 + [DEPS rolls](#deps_rolls)
9 + [Gold and Perf](#gold_and_perf)
10 + [Documentation](#sheriff_doc)
11 * [View current and upcoming sheriffs](#view_current_upcoming_sheriffs)
12 * [How to swap sheriff shifts](#how_to_swap)
13 * [Tips for sheriffs](#tips)
14 + [When to file bugs](#when_to_file_bugs)
15 + [How to close or re-open the tree](#how_close_tree)
16 + [Compile bot failures automatically close the tree](#tree_closers)
17 + [How to revert a CL](#how_to_revert)
18 + [What to do if DEPS roll fails to land](#deps_roll_failures)
19
20
21 <a name="what_is_a_sheriff"></a>
22 What does a sheriff do?
23 -----------------------
24
25 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool.
26
27 Below is a brief summary of what the sheriff does for each task:
28
29 <a name="skia_tree"></a>
30 ### Skia tree
31 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo t).
32 * Start watching the [status page](https://status.skia.org) for bot breakages.
33 * Track down people responsible for breakages and revert broken changes if there is no easy fix.
34 * Close and open the [tree](http://skia-tree-status.appspot.com).
35 * Keep the builder comments on the [status page](https://status.skia.org) upto d ate.
36 * Follow up with the owners of existing [BreakingTheBuildbots bugs](https://code .google.com/p/skia/issues/list?q=label:BreakingTheBuildbots).
borenet 2015/04/02 16:38:38 I'd like to have a point here about pinging (or fi
rmistry 2015/04/02 17:34:05 Done.
37
38 <a name="deps_rolls"></a>
39 ### DEPS rolls
40 * Ensure that [AutoRoll Bot](http://www.chromium.org/blink/blinkrollbot)'s DEPS rolls land successfully.
borenet 2015/04/02 16:38:38 Might be a good idea to point to our ARB front-end
rmistry 2015/04/02 17:34:04 Done.
41
42 <a name="gold_and_perf"></a>
43 ### Gold and Perf
44 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s kia.org/) alerts (by clicking on the bell at the top right of the [status page]( https://status.skia.org)).
45 * The sheriff's duty here is to make sure that when developers introduce new ima ges or new perf regressions, that they are aware of what happened, and they use these tools to take appropriate action.
46
47 <a name="sheriff_doc"></a>
48 ### Documentation
49 * Improve/update this documentation page for future sheriffs, especially the [Ti ps section](#tips).
50
51 In general, sheriffs should have a strong bias towards actions that keep the tre e green and then open; if a simple revert can fix the problem, the sheriff <b>sh ould revert first and ask questions later</b>.
52
53
54 <a name="view_current_upcoming_sheriffs"></a>
55 View current and upcoming sheriffs
56 ----------------------------------
57
58 The list of sheriffs is specified in the [skia-tree-status web app](https://skia -tree-status.appspot.com/sheriff). The current sheriff is highlighted in green.
59 The banner on the top of the [status page](https://status.skia.org) also display s the current sheriff.
60
61
62 <a name="how_to_swap"></a>
63 How to swap sheriff shifts
64 --------------------------
65
66 If you need to swap shifts with someone (because you are out sick or on vacation ), please get approval from the person you want to swap with. Then send an email to skiabot@google.com to have someone make the database change (or directly pin g rmistry@).
67
68
69 <a name="tips"></a>
70 Tips for sheriffs
71 -----------------
72
73 <a name="when_to_file_bugs"></a>
74 ### When to file bugs
75
76 Look at all existing BreakingTheBuildbots bugs [https://code.google.com/p/skia/i ssues/list?q=label:BreakingTheBuildbots](here). If the list is kept up to date t hen it should accurately represent everything that is causing failures. If it do es not, then please file/update bugs accordingly.
77
78
79 <a name="how_close_tree"></a>
80 ### How to close or re-open the tree
81
82 1. Go to [skia-tree-status.appspot.com](skia-tree-status.appspot.com).
83 2. Change the status.
84 * To close the tree, include the word "closed" in the status.
85 * To open the tree, include the word "open" in the status.
86 * To caution the tree, include the word "caution" in the status.
87
88
89 <a name="how_to_submit_when_tree_closed"></a>
90 ### How to submit when the tree is closed
91
92 * Submit manually using the "git cl land" with the --bypass-hooks flag.
93 * Add "NOTREECHECKS=true" to your CL description and use the CQ as usual.
94
95
96 <a name="tree_closers"></a>
97 ### Compile bot failures automatically close the tree
98
99 A failure of the build steps in all compile bots automatically closes the tree. Sheriffs will have to manually reopen the tree manually when they deem the probl em fixed.
100
101 Note: The tree is not closed automatically if the last run of the failed compile builder had the same failing step. The tree is also not closed if the tree was automatically closed less than 10 mins ago. If the tree is already closed then n o action is taken.
102
103
104 <a name="how_to_revert"></a>
105 ### How to revert a CL
106
107 See the revert documentation [here](https://skia.org/dev/contrib/revert).
108
109
110 <a name="deps_roll_failures"></a>
111 ### What to do if DEPS roll fails to land
112
113 A common cause of DEPS roll failures are layout tests. Find the offending Skia C L by examining the commit hash range in the DEPS roll and revert. Keep an eye on the next DEPS roll.
borenet 2015/04/02 16:38:38 The answer here is not always a revert. If we've
rmistry 2015/04/02 17:34:04 I have only encountered situations where the answe
borenet 2015/04/02 17:54:43 Right, this only happens when the committer does s
OLDNEW
« no previous file with comments | « site/dev/METADATA ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698