Issue 1057873003: Revert of make ToLocalCheck crash in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1057873003: Revert of make ToLocalCheck crash in release mode (Closed)

Created:
5 years, 8 months ago by dcarney

Modified:
5 years, 8 months ago

Reviewers:
Sven Panne, Michael Achenbach

CC:
v8-dev, Paweł Hajdan Jr., vogelheim, Dmitry Lomov (no reviews)

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of make ToLocalCheck crash in release mode (patchset #1 id:1 of https://codereview.chromium.org/1043363005/) Reason for revert: breaks some devtools things Original issue's description: > make ToLocalCheck crash in release mode > > R=svenpanne@chromium.org > BUG= > > Committed: https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94 > Cr-Commit-Position: refs/heads/master@{#27585} TBR=svenpanne@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9038004932f3f94b4af13b511827e733fc3bbd08 Cr-Commit-Position: refs/heads/master@{#27589}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	include/v8.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

dcarney

Created Revert of make ToLocalCheck crash in release mode

5 years, 8 months ago (2015-04-02 13:09:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873003/1

5 years, 8 months ago (2015-04-02 13:09:20 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-02 13:09:41 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9038004932f3f94b4af13b511827e733fc3bbd08
Cr-Commit-Position: refs/heads/master@{#27589}