Hide the SVGTextQuery implementation in the .cpp file

Hide the SVGTextQuery implementation in the .cpp file

Mostly renaming and "re-namespacing" in preparation for adding a
different way to perform a query.
Actual code-changes include storing the LayoutObject to query in the
SVGTextQuery instance, and passing it on to executeQuery(). The Vector
of textboxes is moved to the stack of executeQuery(), and the helper
collectTextBoxesInFlowBox() gets a new argument to pass that Vector
around.

BUG=471205, 470326
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193038

[fs, 2015-04-02 13:19:50]

fs@opera.com changed reviewers:
+ ed@opera.com, pdr@chromium.org

[Erik Dahlström (inactive), 2015-04-02 14:15:53]

lgtm

https://codereview.chromium.org/1057853002/diff/1/Source/core/layout/svg/SVGT...
File Source/core/layout/svg/SVGTextQuery.h (right):

https://codereview.chromium.org/1057853002/diff/1/Source/core/layout/svg/SVGT...
Source/core/layout/svg/SVGTextQuery.h:44: LayoutObject* m_queryRootLayoutObject;
Is the LayoutObject expected to stay the same and be valid during the entire
lifetime of the query? If so making it a const reference would be clearer to
readers of this code I think.

[fs, 2015-04-02 14:24:50]

https://codereview.chromium.org/1057853002/diff/1/Source/core/layout/svg/SVGT...
File Source/core/layout/svg/SVGTextQuery.h (right):

https://codereview.chromium.org/1057853002/diff/1/Source/core/layout/svg/SVGT...
Source/core/layout/svg/SVGTextQuery.h:44: LayoutObject* m_queryRootLayoutObject;
On 2015/04/02 14:15:52, Erik Dahlström wrote:
> Is the LayoutObject expected to stay the same and be valid during the entire
> lifetime of the query? If so making it a const reference would be clearer to
> readers of this code I think.

It is, but it can be NULL, so it can't be a reference.

[fs, 2015-04-02 14:33:22]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-04-02 14:33:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057853002/1

[commit-bot: I haz the power, 2015-04-02 14:37:23]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193038