[turbofan] Improve branch folding over phis and ranges.

[turbofan] Improve branch folding over phis and ranges.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/fa7c34764cbc8ee10f1e40e30e4a10a0dbb6084d
Cr-Commit-Position: refs/heads/master@{#27591}

[Michael Starzinger, 2015-04-02 11:59:34]

LGTM, just nits.

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/control-reducer-unittest.cc (right):

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:27: : GraphTest(),
nit: The default constructor should be implicitly called, right?

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:211: Node* p0 =
graph()->NewNode(common()->Parameter(0), graph()->start());
nit: If ControlReducerTest would inherit form TypedGraphTest then we would have
TypedGraphTest::Parameter to express this more concise.

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:236: Node* p0 =
graph()->NewNode(common()->Parameter(0), graph()->start());
nit: Likewise.

[titzer, 2015-04-02 12:35:48]

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/control-reducer-unittest.cc (right):

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:27: : GraphTest(),
On 2015/04/02 11:59:34, Michael Starzinger wrote:
> nit: The default constructor should be implicitly called, right?

I've taken your suggestion of extending TypeGraphTest.

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:211: Node* p0 =
graph()->NewNode(common()->Parameter(0), graph()->start());
On 2015/04/02 11:59:34, Michael Starzinger wrote:
> nit: If ControlReducerTest would inherit form TypedGraphTest then we would
have
> TypedGraphTest::Parameter to express this more concise.

Done.

https://codereview.chromium.org/1057843002/diff/20001/test/unittests/compiler...
test/unittests/compiler/control-reducer-unittest.cc:236: Node* p0 =
graph()->NewNode(common()->Parameter(0), graph()->start());
On 2015/04/02 11:59:34, Michael Starzinger wrote:
> nit: Likewise.

Done.

[titzer, 2015-04-02 12:36:21]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-04-02 12:36:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057843002/20001

[titzer, 2015-04-02 12:45:03]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2015-04-02 12:45:48]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-02 12:45:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1057843002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-02 12:46:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057843002/40001

[commit-bot: I haz the power, 2015-04-02 12:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 12:58:33]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[titzer, 2015-04-02 14:27:44]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-02 14:27:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1057843002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-02 14:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057843002/60001

[commit-bot: I haz the power, 2015-04-02 15:18:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-02 15:18:56]

Patchset 4 (id:??) landed as
https://crrev.com/fa7c34764cbc8ee10f1e40e30e4a10a0dbb6084d
Cr-Commit-Position: refs/heads/master@{#27591}